I've Built a Random Quote Machine

Code Feedback
1

Whassup Campers!!! Just finished my Random quote machine, but it still needs some improvements.
Guys, I need your feedback. Only you can judge this project properly.
Open Random quote machine
Thanx to all Campers, thanx to FCC team!!! God bless you Guys!

2

Nice! The image transitions are a nice touch :wink: The only critique I can think of is it would be nice to see the author attributed to the quote but it’s solid work. Maybe put the quotes, authors and pics together as JSON rather than separate arrays so you don’t have to worry about the order (it can be ‘random’).

var quotes = [{
    text: "Why so serious???",
    author: "The Joker",
    image: "http://res.cloudinary.com/nazarisaak/image/upload/v1493402185/joker_czzmtn.jpg"
  }, {
    text: "If you are cooler than me, would that make me hotter than you?",
    author: "Zach Galifianakis",
    image: "http://res.cloudinary.com/nazarisaak/image/upload/c_scale,w_1631/v1493402266/zach_xluvml.jpg"
  }, {
    ...
  }

];

You’d then access these like so: quotes[index].text and quotes[index].image
`

1 Like
3

YEah, that would be awesome. really appreciate and thank you for feedback! I’ll keep in mind.

4

The pics aren’t occupying the whole screen for me, just the top left 2/3. Other than that I think it’s great. I love the idea of the changing backgrounds, It’s a totally different take on the design aspect of it! Also, your twitter button ended up better than mine.