Just finished the first front end project would love some feedback

here it is!
https://codepen.io/saad-khan-the-sasster/pen/eYBYmbR?editors=0110

It looks good @SaadKhan. Some things to revisit;

  • A link to a font belongs in the head element, not in CSS. In your stylesheet you import the font.
  • On smaller and media screens everything looks good. On a larger screen there’s a horizontal scrollbar. There’s not that’s missing but I can’t get my browser wide enough to get rid of the scrollbar.
  • Don’t use view port units for font sizes. The user should always be in control of the text size on the page (that is, they should be able to manually increase the text size). Using view port units prevents them from doing this. Your job as a developer is to make sure your page is responsive to text size increases. If you don’t know how to manually increase the text size, using Firefox, go to the ‘View->Zoom’ menu and activate ‘Zoom Text Only’. Then while holding down the Ctrl key scroll your middle mouse button to increase the text size. If font-sizes are defined with vw units the only way a user can increase the text size is to widen the browser window. What if the user has really bad eyesight and can’t make the browser window wide enough?
1 Like

thank you so much!

I’ve started fixing these, changing the font sizes issue now this is a great point about the zoom and something I’ve never thought about before. Also, I’m not able to reproduce the horizontal scroll bar on my desktops but I will try on screens outside my laptop. Is this caused because of the way I’m sizing the card div?

I really appreciate your insightful feedback thank you so much once again.

Hi @SaadKhan !

I think your page looks good.

I would suggest using the format tool in codepen.

It will clean up stuff like this.

Keep up the good work!

1 Like

thank you thats very helpful!