My first challenge - Build a Tribute Page

Project Feedback
#1

Hi everyone,

I would like to hear from you what do you think about my first project?

Can you please share with me your thoughts ?

Thanks in advance,

Revital

#2

Hi @RevitalDoukhan,

  • Do not use lower levels to decrease heading font size:
<h1 class="text-primary well-lg">Whitney Huston</h1>
 <h5 class="text-muted 	">August 9, 1963 – February 11, 2012
 </h5>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

**Do not use lower levels to decrease heading font size: use the CSS font-size property instead.**Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

http://w3c.github.io/html/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
https://www.w3.org/TR/html5/common-idioms.html

Cheers and happy coding :slight_smile:

1 Like
#3

Thank you so very much for reviewing my code and sharing your knowledge. I really appreciate it.:slight_smile:

#4

you’re welcome :smile: .

Cheers and happy coding :slight_smile:

#5

According to your advice I changed the code. hope know it’s better :slight_smile:

1 Like
#6