Hi @anishagoyal9717,
Your page looks nice.
Here are my suggestions,
Your page looks nice on my laptop. But, when I view it on my mobile, the whole thing doesn’t fit in the screen anymore. I have to scroll to the right to view the rest of it.
You could use relative positioning to limit the children to its parent container. This is one of the best features of CSS.
On a side note,
The following are the things that I’ve learned from the first three RWD projects I’ve developed.
- Try to fit the page in the screen as much as possible.
- If the content seems not to be fitting in a page, try using relative positioning or media queries to fit the content on the screen.
Happy Coding!
1 Like
Welcome to the forums @anishagoyal9717. Your page looks good. Some things to revisit;
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
)- The test script should be included, with all tests passing, when you submit your projects.
- Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
body
element in HTML. (No need to include thebody
tags). For anything you want to add to the<head>
element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- Mentioning because you have elements out of order. Everything the browser renders belongs in the
body
element. Theheader
element should be in thebody
element. - review this for an understanding of the HTML boilerplate tags
- Mentioning because you have elements out of order. Everything the browser renders belongs in the
- Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- You can ignore the warnings regarding section headers
- Run your CSS through this validator
- Address the errors
- This
</br>
is not a valid HTML element- In addition, do not use the
<br>
element to force line breaks or spacing. That’s what CSS is for.
- In addition, do not use the
- Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation.
hello @naveennavy219 sir,
thank u for sharing for your valuable review .
please check out one more time - i made some changes .
(thank u )
Anisha - Goyal