October 8, 2017, 2:30am
Here is a link to my Random Quote Machine on codepen:
I was hoping I could get some feedback about the project.
Do you like the interface?
Does the code seem to be reasonably well written?
Do you have any other thoughts about it?
I would really appreciate any feedback I can get about it.
You need to make it responsive, because it does not look good on a mobile device or smaller width screen:
As far as the code goes, it seems fine. Since you were going with a minimalist approach, why not take it a step further by rewriting your $.get call as:
var quote = data.quote;
var author = data.author.length ? data.author : 'unknown';
$('#quoteDisplay').html('<p id="quoteText">' + quote + '</p><p id="authorText"> ' + '- ' + author + '</p>');
Finally, why not have a quote load when the page first loads?
October 8, 2017, 5:18am
Thanks for the insights. You’ve made very good points and I really appreciate it a lot. I will make sure to make the appropriate changes. I think this will be a good opportunity for me to practice CSS media queries.
Your buttons don’t look very buttoney.
Consider how buttons usually look:
Font size is similar or slightly smaller than body text
When you hover over them, something changes to indicate that they’re clickable (background color, border color, your cursor, or some combination)
Often, clicking them shows yet another state (e.g. appearing as if the button has been depressed)
Consider using the CSS pseudo-classes
:active to implement some of these effects.