Number Guessing Game - Build a Number Guessing Game

Backend Development
1

Tell us what’s happening:
I have been trying to pass all the tests on the number guessing game but there is one test : " When the secret number is guessed, your script should print You guessed it in <number_of_guesses> tries. The secret number was <secret_number>. Nice job! and finish running" that isn’t passing. I have tried checking for any typo or spaces but nothing looks off. All the manual tests are giving the right result. I am completely at a loss right now on what the problem is. Can you please check it and help me out? Any help will be really appreciated.

Your code so far

PSQL="psql --username=freecodecamp --dbname=number_guess -t --no-align -c"


NUMBER=$(( RANDOM % 1000 + 1 ))

echo -e "Enter your username:"
read USERNAME

#get user_id
USER_ID=$($PSQL "SELECT user_id FROM users WHERE username='$USERNAME'")

#if user_id doesn't exist
if [[ -z $USER_ID ]]
then

  INSERT_USER_ID_RESULT=$($PSQL "INSERT INTO users(username) VALUES('$USERNAME')")
  USER_ID=$($PSQL "SELECT user_id FROM users WHERE username='$USERNAME'")
  echo "Welcome, $USERNAME! It looks like this is your first time here."

#else display game stats
else

  GAMES_PLAYED=$($PSQL "SELECT games_played FROM games WHERE user_id=$USER_ID")
  BEST_GAME_TRIES=$($PSQL "SELECT best_game FROM games WHERE user_id=$USER_ID") 
  echo "Welcome back, $USERNAME! You have played $GAMES_PLAYED games, and your best game took $BEST_GAME_TRIES guesses."

fi
#GAMEPLAY!!!
#while loop for taking guesses
echo "Guess the secret number between 1 and 1000:"
read USER_NUMBER

TRIES=1
while true; do

if [[ $USER_NUMBER =~ ^[0-9]+$ ]] #if input is an integer, continue
then
  if [[ $USER_NUMBER -gt $NUMBER ]]
  then
    echo "It's lower than that, guess again:"
    read USER_NUMBER
    TRIES=$(( $TRIES+1 ))
  else
    if [[ $USER_NUMBER -lt $NUMBER ]]
    then
      echo "It's higher than that, guess again:"
      read USER_NUMBER
      TRIES=$(( $TRIES+1 ))
    else
      
      echo "You guessed it in $TRIES tries. The secret number was $NUMBER. Nice Job!"
      break
    fi
  fi
  else    
 echo "That is not an integer, guess again:"
 read USER_NUMBER
 TRIES=$(( $TRIES+1 ))
fi
done
#echo "broken out of loop"
#increase games played for the user_id and compare if this is best score
if [[ -z $GAMES_PLAYED ]] # if null, it's a new player, so must be inserted
then 
  GAMES_PLAYED=0 
  GAMES_PLAYED=$(( $GAMES_PLAYED+1 ))
  
  GAMES_PLAYED_INCREMENT_RESULT=$($PSQL "INSERT INTO games(games_played,best_game,user_id) VALUES($GAMES_PLAYED,$TRIES,$USER_ID)")
  BEST_GAME_TRIES=$TRIES
else    #not a new player, simple update
  GAMES_PLAYED=$(( $GAMES_PLAYED+1 ))
  GAMES_PLAYED_INCREMENT_RESULT=$($PSQL "UPDATE games SET games_played=$GAMES_PLAYED WHERE user_id=$USER_ID")
  if [[ $TRIES -lt $BEST_GAME_TRIES ]]
  then
 
    BEST_GAME_UPDATE=$($PSQL "UPDATE games SET best_game=$TRIES WHERE user_id=$USER_ID")
  fi 
 
fi  







**Your browser information:**

User Agent is: <code>Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36</code>

**Challenge:**  Number Guessing Game - Build a Number Guessing Game

**Link to the challenge:**
https://www.freecodecamp.org/learn/relational-database/build-a-number-guessing-game-project/build-a-number-guessing-game
2

don’t count the invalid guesses, only the valid ones

1 Like
3

Thanks. I have actually tried that too. I didn’t count the invalid guesses but the problem is still the same. Only that one test isn’t passing even if i don’t count invalid guesses.

4

please share the corrected code as there is no point in looking at the above older version.

5

The corrected code is just the older version with the invalid guess counting removed. Here is the full corrected code:

PSQL="psql --username=freecodecamp --dbname=number_guess -t --no-align -c"


NUMBER=$(( RANDOM % 1000 + 1 ))

echo -e "Enter your username:"
read USERNAME

#get user_id
USER_ID=$($PSQL "SELECT user_id FROM users WHERE username='$USERNAME'")

#if user_id doesn't exist
if [[ -z $USER_ID ]]
then

  INSERT_USER_ID_RESULT=$($PSQL "INSERT INTO users(username) VALUES('$USERNAME')")
  USER_ID=$($PSQL "SELECT user_id FROM users WHERE username='$USERNAME'")
  echo "Welcome, $USERNAME! It looks like this is your first time here."

#else display game stats
else

  GAMES_PLAYED=$($PSQL "SELECT games_played FROM games WHERE user_id=$USER_ID")
  BEST_GAME_TRIES=$($PSQL "SELECT best_game FROM games WHERE user_id=$USER_ID") 
  echo "Welcome back, $USERNAME! You have played $GAMES_PLAYED games, and your best game took $BEST_GAME_TRIES guesses."

fi
#GAMEPLAY!!!
#while loop for taking guesses
echo "Guess the secret number between 1 and 1000:"
read USER_NUMBER

TRIES=1
while true; do

if [[ $USER_NUMBER =~ ^[0-9]+$ ]] #if input is an integer, continue
then
  if [[ $USER_NUMBER -gt $NUMBER ]]
  then
    echo "It's lower than that, guess again:"
    read USER_NUMBER
    TRIES=$(( $TRIES+1 ))
  else
    if [[ $USER_NUMBER -lt $NUMBER ]]
    then
      echo "It's higher than that, guess again:"
      read USER_NUMBER
      TRIES=$(( $TRIES+1 ))
    else
      
      echo "You guessed it in $TRIES tries. The secret number was $NUMBER. Nice Job!"
      break
    fi
  fi
  else    
 echo "That is not an integer, guess again:"
 read USER_NUMBER
 #TRIES=$(( $TRIES+1 ))
fi
done
#echo "broken out of loop"
#increase games played for the user_id and compare if this is best score
if [[ -z $GAMES_PLAYED ]] # if null, it's a new player, so must be inserted
then 
  GAMES_PLAYED=0 
  GAMES_PLAYED=$(( $GAMES_PLAYED+1 ))
  
  GAMES_PLAYED_INCREMENT_RESULT=$($PSQL "INSERT INTO games(games_played,best_game,user_id) VALUES($GAMES_PLAYED,$TRIES,$USER_ID)")
  BEST_GAME_TRIES=$TRIES
else    #not a new player, simple update
  GAMES_PLAYED=$(( $GAMES_PLAYED+1 ))
  GAMES_PLAYED_INCREMENT_RESULT=$($PSQL "UPDATE games SET games_played=$GAMES_PLAYED WHERE user_id=$USER_ID")
  if [[ $TRIES -lt $BEST_GAME_TRIES ]]
  then
    #echo "testing best game update"
    BEST_GAME_UPDATE=$($PSQL "UPDATE games SET best_game=$TRIES WHERE user_id=$USER_ID")
  fi 
 
fi
6

Case matters in these tests

2 Likes
7

Yeah, i figured it out finally after hours. I was using Job instead of job. Took me forever to actually find it :laughing: