Number guessing game not passing

Backend Development
1

@hbar1st, I am struggling with getting one last test to pass in the number guessing game. Please help.

The test that is not passing is:

If that username has been used before, it should print Welcome back, <username>! You have played <games_played> games, and your best game took <best_game> guesses. , with <username> being a users name from the database, <games_played> being the total number of games that user has played, and <best_game> being the fewest number of guesses it took that user to win the game

My script is below:

#!/bin/bash
PSQL="psql --username=freecodecamp --dbname=number_guess -t --no-align -c"

# Generate random number between 0 and 1000
SECRET_NUMBER=$(( ( RANDOM % 1000 ) + 0 ))

# Initialize guess count
GUESSES=0

# Prompt for username
echo -e "Enter your username:"
read NAME

# Check if the user exists in the database
USER_DATA=$($PSQL "SELECT username, games_played, best_game FROM games WHERE username='$NAME'")

# If user doesn't exist, welcome them as a new user
if [[ -z $USER_DATA ]]; then
  echo "Welcome, $NAME! It looks like this is your first time here."

  # Insert the new user into the database with default values
  $PSQL "INSERT INTO games(username, games_played, best_game) VALUES ('$NAME', 1, 1000)"
  GAMES_PLAYED=1
  BEST_GAME=1000

else
  # Parse the retrieved data for returning users
  IFS="|" read USERNAME GAMES_PLAYED BEST_GAME <<< "$USER_DATA"
  
  # Increment games played
  ((GAMES_PLAYED++))

  # Update games played in the database
  $PSQL "UPDATE games SET games_played=$GAMES_PLAYED WHERE username='$USERNAME'"

  # Welcome back message with games played and best game stats
  echo "Welcome back, $USERNAME! You have played $GAMES_PLAYED games, and your best game took $BEST_GAME guesses."
fi

# Prompt the user to guess the secret number
echo -e "Guess the secret number between 1 and 1000:"

# Loop to keep asking for guesses until the user guesses correctly
while true; do
  read GUESS

  # Increment guess count
  ((GUESSES++))

  # Validate input (ensure it's an integer)
  if [[ ! $GUESS =~ ^[0-9]+$ ]]; then
    echo -e "That is not an integer, guess again:"
  else
    # Provide hints and guidance for guesses
    if [[ $GUESS -lt $SECRET_NUMBER ]]; then
      echo -e "It's higher than that, guess again:"
    elif [[ $GUESS -gt $SECRET_NUMBER ]]; then
      echo -e "It's lower than that, guess again:"
    else
      # Correct guess! Check if it's the best game
      if [[ $GUESSES -lt $BEST_GAME ]]; then
        # Update the best game in the database if current game is better
        $PSQL "UPDATE games SET best_game=$GUESSES WHERE username='$USERNAME'"
      fi

      # Display the success message
      echo "You guessed it in $GUESSES tries. The secret number was $SECRET_NUMBER. Nice job!"
      exit
    fi
  fi
done
2

Thanks. I’ve been able to solve it by creating two tables:

CREATE TABLE players (
 mod edit: schema removed
);

CREATE TABLE games (
mod edit: schema removed
);
3

I’ve removed the schema from the post to avoid spoilers. (but I left the comment so it can help others).

1 Like