Periodic Table Database Project -Passing "If you run ./element.sh, it should output Please provide an element as an argument. and finish running."

Backend Development
1

I have passed all other test except for the “If you run ./element.sh , it should output Please provide an element as an argument. and finish running.”.
I’m not sure why I cannot get it to pass, so any help is appreciated.

https://github.com/joshuabuck-data/Periodic-Table-Database

element.sh

#! /bin/bash
 
PSQL="psql --username=freecodecamp --dbname=periodic_table --tuples-only -c"


if ! [[ -z $1 ]]
  then
    ELEM="$1"
else 
  echo "Please provide an element as an argument."
  read ELEM
fi

if ! [[ -z $ELEM ]]
  then
    PSQL="psql --username=freecodecamp --dbname=periodic_table --tuples-only -c"
    NUMLIST=($($PSQL "SELECT atomic_number FROM elements;"))
    SYMBLIST=($($PSQL "SELECT symbol FROM elements;"))
    NAMELIST=($($PSQL "SELECT name FROM elements;"))

  if [[ ${NUMLIST[*]} =~ $ELEM ]]
    then 
        ATOMNUM=$($PSQL "SELECT atomic_number FROM elements WHERE atomic_number='$ELEM';")
  elif [[ ${SYMBLIST[*]} =~ $ELEM ]]
    then
        ATOMNUM=$($PSQL "SELECT atomic_number FROM elements WHERE symbol='$ELEM';")
  elif [[ ${NAMELIST[*]} =~ $ELEM ]]
    then
        ATOMNUM=$($PSQL "SELECT atomic_number FROM elements WHERE name='$ELEM';")
  else
        BILLY=66 #echo "I could not find that element in the database."
  fi

  if ! [[ -z $ATOMNUM ]]
    then
      NAME=$($PSQL "SELECT name FROM elements WHERE atomic_number=$ATOMNUM;")
      SYM=$($PSQL "SELECT symbol FROM elements WHERE atomic_number=$ATOMNUM;")
      TYPE=$($PSQL "SELECT type FROM types full join properties on types.type_id = properties.type_id WHERE atomic_number=$ATOMNUM;")
      MASS=$($PSQL "SELECT atomic_mass FROM properties WHERE atomic_number=$ATOMNUM;")
      MP=$($PSQL "SELECT melting_point_celsius FROM properties WHERE atomic_number=$ATOMNUM;")
      BP=$($PSQL "SELECT boiling_point_celsius FROM properties WHERE atomic_number=$ATOMNUM;")
      SYMF="$(echo $SYM | sed 's/ *$//')"

      echo -e "The element with atomic number"$ATOMNUM" is"$NAME" ("$SYMF"). It's a"$TYPE", with a mass of"$MASS" amu."$NAME" has a melting point of"$MP" celsius and a boiling point of"$BP" celsius."
    else 
     echo "I could not find that element in the database."
  fi

else 
    echo "I could not find that element in the database."
fi
2

Could you post dump of your db as well?

3

My bad, I have added the link to my dump. Thank you :slight_smile:

4

The task expects program to exit after the printed text, if there’s no argument provided.

1 Like
5

Thank you so much, I realize now that the shell should only accept input before running, and not during.