The regEx you are creating is looking for uppercase letters but on the very next line you are converting the entire string to lowercase so when you use regEx there will never be any uppercase letters to match on.
Also, using your regEx to replace an upper case letter with - doesn’t make sense since you don’t want to replace existing letters with a -.