Pomodoro Clock - I'd love some comments

Code Feedback
1

I’d be really grateful for some comments about my code, styling, strategy, or anything else about this project. It’s built with React and I pushed everything into CodeSandebox.

Check it out here --> https://codesandbox.io/s/0qzywnom7v

Thanks!

3

Thanks for catching that! I’ll work on it.

4

Alright, I’ve got it now. The buzzer goes at 00:00, but I still have it change the label (Session to Break) when the time changes, which makes more sense to me since the new session/break should start with its full time and not 00:00.

Also, from what the User Stories say it should go:

00:02
00:01
00:00
01:00
00:59

And it does that now.
What do you think?

6

Of course you’re right, but in the user stories for this project (if I understand correctly) it says “User Story #23: When a session countdown reaches zero (NOTE: timer MUST reach 00:00), a new break countdown should begin, counting down from the value currently displayed in the id="break-length" element.”

So I have to display 1:00 again. I actually did what you said the first time and it wouldn’t pass the test saying that the minutes display 0 instead of 1.

7

The example project does the same: https://codepen.io/freeCodeCamp/full/XpKrrW

9

Ah, ok! Yeah, I totally agree then.

There were a few things in the user stories that limited the project actually, for instance, the timer HAS to start at 1, and can’t start at 01. which makes formatting a bit funny.

Thanks again.

11

Hmm, I guess it could be interpreted that way, but when it says “from the value displayed” it sounds to me like it should start at that number. Either way, when you set it up to start at 00:59 instead of 1:00, it won’t pass the test.

I agree with you that it makes more sense to do it that way, it just won’t pass the test.