Project Feedback - Survey form nosmaritimos

Code Feedback
1

Hello all,
Could you provide some feedback on my survey form?
I tried not to repeat mistakes from last project:

  • Not using
    for space;
  • No scrolling issues;
  • Added some more responsiveness;
    *Focus using tab makes sense;
    *Tried to use acessibility tags .

Github: https://github.com/Nosmaritimos/fcc-survey_form
Codepen: https://codepen.io/nosmaritimos/pen/oNzrzwO

Thank you very much,
Raphael Pazos

2

Your form looks good @nosmaritimos. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • codepen knows the body tag is in HTML. You don’t need it just because you’re using it for styling in the CSS editor.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • User’s should be able to click on the label to toggle a selection, not just the radio button / checkbox
  • Change the cursor to a pointer when hovering over the submit button
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens

On a side note, you could add a little more to the focus indicator. The default is very hard to see.

3

Hello @Roma,
I believe I have corrected everything, thanks for the feedback.
The thing you said about “add a little more to the focus indicator” was brillant.
Codepen: https://codepen.io/nosmaritimos/pen/oNzrzwO
Thanks

4

Nice job cleaning everything up @nosmaritimos.
Look forward to seeing your next project!

5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.