Tell us what’s happening:
Hello everyone I just completed the random quote machine certification project .
I would greatly appreciate any feedback u can give me, thank u!
I decided not to go for create-react-app for this one.
Create-react-app seemed like a little bit overkill for such small project.
Anyway this looks a little better than mine.
I don’t understand this link: by [Joel WebDev](https://randomequotejhweb.netlify.app/#)
It kind of leads to the page which is before my eyes already.
And it looks like your favicon is the same as the default one from create-react-app template(react logo I mean) - that was the plan or you forgot to delete it?
Thanks for the comment , yea i built it with react and bootstrap.
I forgot to remove the favicon and change the link thanks for pointing that out .
For the design, i tried to make it as close as the example
Yeah, when you are using create-react-app you have to know which files you can delete without breaking the project.
In this case, the following files can be safely deleted:
logo192.png
logo512.png
removing references of those logos in the manifest.json file
web vitals
setup tests
App.test
I don’t think there is anything wrong with not using CRA for small projects like this as long as you follow the same design architecture of a react app.
There are plenty of articles out there like this one where you can build out react template
The tweet button doesn’t work. It should open a new tab/window with the quote text as part of the tweet. Look at the example project.
data is a pretty unspecific name, maybe name it what it is, the quotes.
The colors array is fixed and as such, it can be moved out of the handler and the component. That way is it not recreated on every click/render.
You do not really need to pass the Quote component the colors as its parent already is given a style object and the children will inherit the colors. I also think the name bgColor for a style object with both background-color and color might be better. Maybe just styles or something.
As an aside, give Vite a look for a nice alternative to CRA.
Vite - it is the thing they are using on replit, right(well, at least for React repl-s - that’s what I am playing around now)? I got started with replit just couple of hours ago - and I already like what’s going on there. so thanks for the hint about Vite.