Rate my first project

Code Feedback
1

https://codepen.io/bej-d-vid/pen/YzpGYWd
Let me know what would you change.

2

i think as a general page this is very nice :slight_smile: simple and effective. Not all pages need to be fancy and have a ton of unneccesery design / functionality!

As a tribute page i think its great…

1 Like
3

Welcome to the forums @bejodavid123. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
    • The test script is JS and will not run when place in the head element. Codepen is forgiving which is why it works here.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
      • Remember, an id must be unique within the document
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for. And don’t use it to create a new paragraph. If you want multiple paragraphs then use multiple paragraph elements.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia entry” is not accessible
2 Likes
4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.