Record Collection first challenge

JavaScript
1

Tell us what’s happening: It is not marking this "After updateRecords(5439, "artist", "ABBA") , artist should be "ABBA". Please what’s wrong with my code?"

Your code so far


// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [ 
        "Let It Rock", 
        "You Give Love a Bad Name" 
      ]
    },
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [ 
        "1999", 
        "Little Red Corvette" 
      ]
    },
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    },
    "5439": {
      "album": "ABBA Gold"
    }
};
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
  if (prop !== "tracks" && value !== "" ) {
    collection[id].album = value;
  } else if (prop === "tracks" && collection[id].hasOwnProperty("tracks") === false) {
    collection[id].tracks = [];
    collection[id].tracks[0] = value;
  } else if (prop === "tracks" && value !== "") {
    collection[id][prop].push(value);
  } else {
    delete collection[id][prop];
  }
  
  return collection;
}

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/record-collection

2

This logic is setting album to “ABBA” instead of artist:

  if (prop !== "tracks" && value !== "" ) {
    collection[id].album = value;
  }
1 Like
3

Ohhhh…I’ve rectified it. I created another statement setting artist to the value. It worked.
Thanks so much.

4

why are not you using the prop variable instead?

5

where exactly please?

6

you are using collection[id][prop] when you could use collection[id].tracks (because you already checked that prop === "tracks"), but when you don’t know what prop's value is you don’t use prop (you just know that prop !== "tracks")

7

Bingo!! It worked that way too. I also saw where the initial error was from. It was from this :arrow_down: line.
It should have been collection[id][prop] = value;. Thank you very much.