Seeking Feedback on Tribute Page

Code Feedback
1

Hi I am seeking feedback on my Tribute Page. Please let me know what you think!

Thanks!

1 Like
2

I like it! The color scheme works well together. The image caption seems to be cut off.

Possibilities:

  • Maybe consider putting a max-width on elements that stretch unnecessarily wide on larger screens, like the timeline div.
  • In the timeline, sometimes you use syntax like ‘She opened…’ and sometimes just ‘Moved…’ You could make that consistent.
  • Increase line-height or padding/margin of ‘li’ items in timeline for readability.

I love learning new things from these tribute pages! :heart:

1 Like
3

Thanks @vjones2112 for your input!

4

Your page looks good @MeganKnop. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
    • Mainly mention because the link to the font would go in the head element, not in the body. (codepen is forgiving)
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Review the lesson about giving meaningful text to links.
  • User’s are not seeing your page the way you want them to. You’ve loaded a font for the title but are calling it incorrectly so user’s see the default font.
    • Fonts with a space in the name need to be in quotes. You also should specify a backup font. Google fonts shows you the CSS rules you need to use.
5