Survey form project feedback before submitting

Code Feedback
1

Hello everyone,

I’m posting the survey form project for your feedback, is it good? acceptable? terrible?

https://codepen.io/moustafa-ahmed/pen/KKdwvbg

This is my first project in coding, I’m new to HTML and CSS, decided to start with this before the tribute as I thought its easier, so I returned to basic challenges in almost every step, is that normal or should I review everything again before starting the projects?
Thanks in advance.

2

Look amazing!, with a lot of practice and dedication you will get better results.

It is normal that with each project you have to go to previous challenges, we all go through that, and whoever says otherwise lies!

Two tips:
1- Do not try to learn everything at once, just remember that this ‘something’ exists and then when you need it you look for how to use it.

2- Always look for documentation on sites like: “developer.mozilla”, “W3Schools”, “css-tricks”, etc.

With a lot of practice you will realize that you will not need to go to previous challenges or anything, everything will be in your head. Good luck! :smiley:

ps: Sorry for the bad English

2 Likes
3

Welcome to the forums @moustafa111x. Your form looks okay but there are things you need to revisit;

  • When using codepen it only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your font would go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are errors you need to fix. Remember, an id must be unique within the document.
  • As far as grouping your radio buttons and checkboxes. Look at the <fieldset> tag and the associated <legend> tag.
  • Don’t use the <br> tag to force spacing or line breaks.
  • All of your styling should be external.
    • You have this one instance of in-line: style="text-align:left;
  • Change the cursor to a pointer when hovering over the submit button.
  • Your form needs to be responsive. All of your inputs overflow your form container on large screens. On small screens it’s not legible.
4

I have submitted the solution (tests showed all passed) , so these changes won’t take effect right?

5

If you do the changes in the same pen it’s okay. The solution will pick up the changes.
If you decide to create another pen to do the changes (though there is no need to) then you’d have to resubmit the project with the new URL.

Yes, the user stories all pass. What I’m talking about is HTML coding errors that you’ll see when you run it through the validator.

1 Like
6

Okay, thanks a lot sir.

7

I think I have fulfilled all your comments, the curriculum page doesn’t show a checkmark on the project, does that mean it hasn’t been submitted yet?

8

It’s pretty good, I like how you put the text between the lines, the placeholder, as well as the font you used. Good job.

1 Like