Hey guys, I just finished the technical documentation challenge and would love your feedback.
Thank you 
Hey, this is a good start but you’ve got some issues that need fixing.
- While in wide view (the menu is showing on the left side) if I decrease the height of my browser so it is shorter than the menu then the bottom of the menu disappears and I can’t scroll to get it back.
- In narrow view (the hamburger icon is showing) when I expand the menu and click on a link nothing happens.
- I cannot use the keyboard to click on the hamburger icon (I would suggest you use a
<button>for this which will automatically make it keyboard accessible). - Technically, the white headings on that background color do not have enough contrast to be accessible. Use the WebAIM contrast checker to make sure your contrast levels are big enough.
- You have no headings on the page. The white headings on the content page should be
<h2>s. The white heading on the menu should be the<h1>. Personally, I would move this<h1>out of the<nav>so it is a sibling of the<nav>but I understand if you can’t because this project requires it to be in a header inside the nav.
1 Like
Thank you so much for taking the time to review my work. I appreciate the feedback, I’m gonna work on all the issues and I’ll come back with an updated version.
Hey @bbsmooth , here is my updated website. On small screens when you click a link in the menu it seems like nothing happens but the page scrolls to the section but I was unable to make the menu disappear after you click. Any pointers on how to do it without JS.
Thank you
No, there isn’t a way to do that without JS.
Also, you would probably use a <button> for the hamburger icon but I understand why you are using a checkbox here.
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.