Tribute Page: Completed

Code Feedback
1

Hey y’all, hope y’all doing great. Just wanted to get some feedback for the tribute page challenge. I wanna what y’all think and if can gimme some advice , mostly about how to organize my code I’d really appreciate that. I added a navigation bar just because I think it looks cool but I also wanted to practice how to make one.

Here is my page: https://codepen.io/ZakOnif/full/rNWGzRb

Challenge: Build a Tribute Page

Link to the challenge:

2

Welcome to the forums @ZakM1. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the style tags in codepen’s CSS editor.
    • the style tags are only used in the head element of HTML. They would never be used in an external stylesheet
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens

On a side note, since you’re asking for feedback I’m moving this to the #project-feedback subforum. It will get you more eyes-on.

3

Cool, thanks. I will revisit everything you pointed out and improve. Thanks again.

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.