Hi FCC community, hope you’re doing well!
I was wondering if I could get your guys feedback on my Tribute Page Project. You can find the project by following this link.
At the bottom of this post you can find out some of the specific areas I would really appreciate getting feedback for but before the list I’d like to ask for help on completing the last test.
TL;DR -> the page doesn’t pass the img responsiveness test but the img is definitely responsive. suggested max-width property for img element conflicts with extra wrapper css.
If you run the little JS test embeded in the top left corner, you’ll see that my projects fails the test for the image responsiveness. If you resize the page or open it up on any device over 320px, you’ll see that the resizing is okay on different screen sizes. The test suggests using the max-width property on the image element but doing so kinda ruins the image for me. What I used was another wrapper div, named cropper in CSS to do a bit of image manipulation and get a really nice looking circular shape. I applied this because the image I’m using isn’t square-shaped and using just border-radius on the image would produce an ellipse rather than a circle, but if I tweak the image using the cropper it looks perfect. I took care of the responsiveness in several cascading media queries by basically scaling down the image as the screen gets smaller.
The stuff I’d appreciate feedback on is:
- General responsiveness
- Code structure
- Visual design
Any other feedback is welcome too of course