Tribute Page Feedback

Code Feedback
1

Hello Guys! I have recently completed the tribute page task, and I would like to get some valuable feedback from you guys on areas where I can improve myself :upside_down_face:
Here’s link to the project:
Page Link
Page Source Code

2

I’m not an expert in HTML/CSS by any stretch, but the page looks really nice. Good work!

1 Like
3

It looks good.

  • I would suggest you limit your line lengths to no more than 120 characters. You can use a max-width with the ch unit and center the text elements container.

  • You might also want to limit the max width on the outer container, 70vw is pretty wide on large monitors. I might also give the text element containers a bit of padding so the text never touches the edge.

  • I would increase the font size and line height as well. It just helps the readability. Speaking of which, pure white text on a pure black background can cause eye strain.

Good job, keep it up.

1 Like
4

I’ll try to implement these points. Thanks, @lasjorg for your valuable feedback.

5

Thanks, @JeremyLT, for the feedback :smiley:

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.