Tribute page layout test

1

can’t get why its failing the layout test
https://codepen.io/advitya-sharma/pen/JjYVRRO

2

Well, for the first problem, you should have a section with an id called welcome-section. There isn’t anything like that.

Would you like to look at my code from this challenge to understand?

3

you have to just make your image responsive
do something like this:

#image{
  max-width: 100%;
  max-height: 100%;
}

Otherwise your page is looking good

4

only those things make an image responsive ?

5

Hey, that’s the magic of coding :wink:

6

this dont seem to work

7

sure ,I didnt saw mention of welcome section anywhere

8

Well, if you go to the little test section in your console and press on the red button that says your code is incorrect, it tells you what is required of you to pass the test.

9

I pressed it and you have ten different things you have wrong.

10

https://codepen.io/hopefulcodegirl/pen/vYNpgmV

Here is my code to help you get an idea.

11

But do you see what I am talking about?

12

omgosh! wait!!! You made a mistake!

13

Your test is set to personal portfolio! Change it to tribute page! Everything will change!

14

image
image781×65 3.7 KB

Here’s the error code I get.

15

I’m testing it with tribute page,I saw your code it has max-width in #image ,I added that but still not working

16

whit this is passing 10/10 !!!

17

set the height in your CSS to auto

i just tried it. It will work. Put it in your #img in CSS.

height: auto

18

you just have to set max-width and max-height of #image to 100%

19

passed,I did height width to auto then changed max width and height

20

hooray! Are you thrilled!?