Tribute page-Nhs

Code Feedback
1

Hi everyone,
I’ve just completed my first tribute page. Not been doing Html/Css for long but would love a career in it one day so I’m determined to keep on improving.
Thanks
Adie
link to my tribute page

2

Your page looks good @grover_as. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
    • Mentioning because there are elements out of order. Review this for an understanding of the HTML boilerplate tags.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia entry” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens.
      To help with responsiveness try using relative units rather than hard coding pixel units.
3

Hi Roma,
Thanks for the feedback and help I think I’ve addressed all the errors on my Tribute page now.

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.