Tribute page to Michael Jordan - Feedback Welcome

Tribute page to Michael Jordan - Feedback Welcome
0.0 0

#1

Hi guys,

Here is my tribute page - https://codepen.io/konstantin78/pen/wyKjjY
I’m welcoming any feedback with code suggestions.

Thank you!!!


#2
  • Read this to learn how to add external resources to codepen - https://blog.codepen.io/documentation/editor/adding-external-resources/
  • However i’d advise you to write vanilla code for now. Libraries are helpful in production, but are a crutch when learning (especially bootstrap and jquery).
  • tidy up your code and research about max characters per line of code
  • don’t use ids and html elements for styling, that’s what classes are for
  • why do your tags have names? Why are all the names the same? Why are you using a form when you’re not actually submitting a form?
  • avoid full-width buttons, they just don’t look good
  • your social media buttons become full width on narrower resolutions
  • you set a line-heght: 150%, make sure you understand what that means - https://stackoverflow.com/questions/6071987/line-height-as-a-percentage-not-working

Проекта ти е много добър и ти пожелавам успех в развитието ти!


#3

Благодаря за съветите, много полезни!