Tribute Project feedback-RWD

Code Feedback
1

Above is my tribute page for Responsive web design. Please share your valuable feedback and suggest any improvements.

2

Hey, Good work!

  • You need to use the figcaption instead of the caption tag
  • You could reduce the width of the img-div so you don’t get a horizontal scroll
3

Welcome to the forums @svra911. Your page looks good. Some things to revisit;

  • Verify your email addr with codepen so we can see your page full view
  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    The test script, with all tests passing, should be included when you submit your projects.
    Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    There are HTML syntax/coding errors you should be aware of and address.
  • In addition to being used incorrectly in most places in your code, there is another instance where you should not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    Reference MDN Docs
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    “wikipedia entry” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    There’s a horizontal scrollbar on large and small screens
4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.