Asking for reviews

Code Feedback
1

Tell us what’s happening:
Hello super campers,
Please I want to ask for reviews on my product landing page. This will help me improve next time and probably correct some mistakes I might not have noticed.
Thanks

Your code so far
Follow this link to check
https://codepen.io/ugoamaka/pen/vYNrKeg

Your browser information:

User Agent is: Mozilla/5.0 (Linux; Android 8.1.0; CPH1909 Build/O11019) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Mobile Safari/537.36.

Challenge: Build a Product Landing Page

Link to the challenge:

2

Page looks good @ugoamaka. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for HTML misses things which is why I recommend W3C
    • The one for CSS is good. Use it, there’s something to clean up.
  • Really, really hard to see the links in the navbar. Purple on purple doesn’t provide contrast. Doesn’t matter that it changes slightly when hovered. What about smaller screens where there is no mouse to hover?
  • Something to come back to as you learn more. When clicking on a navbar link the top of the section is hidden under the navbar.
3

I believe I have added the code to make the navlinks stay white but it still changes to the link’s default color thus providing a very poor contrast with the background.
I don’t understand what I am not doing right.
please help @Roma