Build a Personal Portfolio Webpage (unable to pass 1 of the test)

HTML-CSS
1

Tell us what’s happening:
I have created just the outline for portfolio .
I am not able to fix the 1 of the test (The height of the welcome section should be equal to the height of the viewport.)

I have given height: 100vh; for welcome-section.

Your code so far


Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3432.3 Safari/537.36.

Link to the challenge:

2

you specified the welcome section selector like this:

.welcome-section{

but you used an id attribute in the html so the class selector (dot) will not work

#welcome-section {
3

Thanks , my bad :frowning:

Have a nice day :slight_smile:

4

@hbar1st- I have changed it, it is still failing.

5

Couple of things:

You need to define the viewport meta tag. Click the html settings in codepen to add it.

Your header is taking up some height in the page. This prevents the welcome from being the full available viewport height.
Either get rid of the header (by putting navbar inside the welcome section) or define it in such a way that its height appears to be zero.

There are many portfolios implemented on fcc, look thru these for ideas.

1 Like
6

still stuck :frowning: .Need Help .

I have added meta tag in html setting of codepen but still it fails.

7

Looks like you are off by exactly 2 pixels. These two pixels are from the border you applied around everything in your css… try specifying the border around specific things and using box-sizing to include the border.

1 Like
8

Thank you . Border was the reason. :slight_smile: