Completed my Survey Form

Code Feedback
1

Comment your reviews on my work on Survey Form to help me be better at this.


Regards,
:smiley:
2 Likes
2

Hey @urfrenznimubro
You form looks.
But you have missed something.

  • The test shows the mark as 13/17 please make the change.
  • Change the heading and tagline font it is not clear.
  • Run the code in the W3C validator, There errors to correct.
  • donā€™t use br, that why CSS is there.
  • Add text at the footer like ā€œMade by urfrenznimubroā€

Please make these changes.

Hope this helps you,
Thanks,
Codely

1 Like
3

Oh yes!! I totally forgotā€¦Iā€™m now working on it.
Thanks for letting me know.

2 Likes
4

Great job @urfrenznimubro. Keep It up! Waiting to see the final version!

2 Likes
5

Just finished updating the Survey Form.
Please send you feedback :smiley:

1 Like
6

Your form looks good @urfrenznimubro. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ā€˜Analyzeā€™ link.
    • The one for CSS is good. Be wary of duplicating selectors.
    • (The one for HTML misses things which is why I recommend W3C)
  • Userā€™s should be able to click on the label to toggle a selection, not just the radio button / checkbox.
    • correcting the errors from W3C will fix this issue
  • Do not use the <br> element to force line breaks or spacing. Thatā€™s what CSS is for.
7

Thank you for your feedback. Iā€™ll work on improving my work .

8

Hi @urfrenznimubro. Good job! I like the form and your project is super responsive!
Some opinions:

  • The label font-size is smaller than the placeholder text. Please make it a little bit bigger.
  • Add a placeholder for the textarea.
  • I canā€™t check the ā€œDrumsā€ checkbox by clicking on its label. This is because you specified drumsl inside the label's for attribute whereas the id of the input is drums.
  • You donā€™t need the body tags in CodePen.

Anyway, great job! Waiting to see your next project!

9

Thank you for your feedback.
Iā€™ll work on it.

1 Like