Debug an ISBN Validator - Debug an ISBN Validator

Tell us what’s happening:

My code is not passing the test “Invalid character was found”, please suggest what’s wrong in my code?

Your code so far

def validate_isbn(isbn, length):
    if len(isbn) != length:
        print(f'ISBN-{length} code should be {length} digits long.')
        return
    main_digits = isbn[0:length-1]
    given_check_digit = isbn[-1]
    main_digits_list = [int(digit) for digit in main_digits]
    # Calculate the check digit from other digits
    if length == 10:
        expected_check_digit = calculate_check_digit_10(main_digits_list)
    else:
        expected_check_digit = calculate_check_digit_13(main_digits_list)
    # Check if the given check digit matches with the calculated check digit
    if given_check_digit == expected_check_digit:
        print('Valid ISBN Code.')
    else:
        print('Invalid ISBN Code.')
def calculate_check_digit_10(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 9 digits by its corresponding weight (10 to 2) and sum up the results
    for index, digit in enumerate(main_digits_list):
        digits_sum += int(digit) * (10 - index)
    # Find the remainder of dividing the sum by 11, then subtract it from 11
    result = 11 - digits_sum % 11
    # The calculation result can range from 1 to 11.
    # If the result is 11, use 0.
    # If the result is 10, use upper case X.
    # Use the value as it is for other numbers.
    if result == 11:
        expected_check_digit = '0'
    elif result == 10:
        expected_check_digit = 'X'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def calculate_check_digit_13(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 12 digits by 1 and 3 alternately (starting with 1), and sum up the results
    for index, digit in enumerate(main_digits_list):
        if index % 2 == 0:
            digits_sum += digit * 1
        else:
            digits_sum += digit * 3
    # Find the remainder of dividing the sum by 10, then subtract it from 10
    result = 10 - digits_sum % 10
    # The calculation result can range from 1 to 10.
    # If the result is 10, use 0.
    # Use the value as it is for other numbers.
    if result == 10:
        expected_check_digit = '0'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def main():
    user_input = input('Enter ISBN and length: ')
    if ',' not in user_input:
        print("Enter comma-separated values.")
        
        
    # if user_input!=int:
    #     print("Length must be a number.")
    #     print("Invalid character was found.")



    values = user_input.split(',')
    try:
        isbn = values[0]
        length = int(values[1])
        print(isbn)
        
        if not isinstance(int(isbn[0:-1]), int):
            print('Invalid character was found.')
        if length == 10 or length == 13:
            validate_isbn(isbn, length)
        else:
            print('Length should be 10 or 13.')
        

    # except IndexError:
    #     print('Enter comma-separated values.')       
    except ValueError:
        print('Length must be a number.')
    except Exception:
        print('Invalid character was found.')
    
     

# main()


# i/p ==> 080442957X,10
# o/p ==> Valid ISBN Code.

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/148.0.0.0 Safari/537.36

Challenge Information:

Debug an ISBN Validator - Debug an ISBN Validator

GitHub Link: freeCodeCamp/curriculum/challenges/english/blocks/lab-isbn-validator/686b9720ee1d032bd77a480a.md at main · freeCodeCamp/freeCodeCamp · GitHub

are you testing your app?

it seems this is triggered.

what happens here when int("15-005112") runs?

It gives following output:

length must be a number.

I am specifically asking for int("15-005112"), have you tried testing it in isolation?

It gives following output:

ValueError: invalid literal for int() with base 10: ‘15-005112’

so you need to change what you are doing, or this will also be catched by except ValueError:

I am not getting how to handle two ValueError simultaneously, could you please help me on that?

you need to change the approach on how to check if the isbn has all valid digits