Do you have any feedback for me? =)

Code Feedback
1

Hi :smiley:

I’ve just finished my Tribute Page project.

And I would really appreciate it if you give me some feedback on it. What can I do better the next time?

Thanks a lot for all your help!

2

Hi @fernanda_ricciardi !

Welcome to the forum!

I think your page looks good.

I would include the test suite in your page.
People usually like to check if all tests are passing.

The click here link is not that accessible.
So I would review that FCC lesson on giving links meaningful titles.

Keep up the good work!

1 Like
3

Welcome to the forums @fernanda_ricciardi. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “here” is not accessible
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • Reference MDN Docs
    • If you want multiple paragraph elements then code multiple paragraph elements. And don’t use it for spacing / line breaks.
1 Like
4

Hi @jwilkins.oboe and @Roma ! :slight_smile:

Thank you very much for your feedback. I have upgraded my page according to your advice.

Cheers!

5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.