Hello, Can anyone give me feedback on my tribute-page?

[nimerria19]

Hi,

My first freecodecamp project is almost finished and I was wondering, if anybody would give me feedback.
That would help me a lot.

Here’s the link:

Tribute Page

Thanks in advance

[emanzulfiqar]

Hi @nimerria19 Your page is nice but somethings to revisit:

1. Your page is not responsive and shows a scrollbar at the bottom. Make your page responsive.

2. Analyze your HTML and CSS, like this:
   

3. Run your HTML code through the W3C validator . There are HTML coding errors you should be aware of. Since copy/paste from codepen you can ignore the first warning and first two errors.

4. Maybe you removed the test table link. Some of your tests are failing. Make sure to pass all those tests.

5. Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links . For a more thorough explanation read Web Accessibility in Mind . “ Wikipedia ” is not accessible.

Happy Coding!

[nimerria19]

Hey, @emanzulfiqar

Thanks for your time to review my code.
Since your feedback, I’ve solved majority of the errors and passed the test table. Also updated the link

Thanks again

[Roma]

Welcome to the forum @nimerria19. Your page looks good. Some things to revisit;

• Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
  • “her wikipedia page” is not accessible
• black text on a black background gives no contrast at all. If in doubt, use a contrast checker.