FCC-Landing Page Project Feedback (Complete)

Code Feedback
1

Hello Campers!

I am done with the third project. Here is the link: https://codepen.io/joesh/full/OJVeJaM Please go through it and give your feedback and suggestions on how to improve my code.

Thank you

2

You page looks good @joshem. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are some errors you can clean up.
  • Not sure if you noticed but your font, Poppins, is not showing up. Your page is using the default sans-serif
    • When you link to a font, that goes in the head of your HTML. In the case of codepen you click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • If you want to call your font in CSS then you import it. It’s a different call. You just don’t add import in front of the link.
    • when you click on the embed link in Google Fonts it defaults to link. You have to click @import to get the import link for CSS.
    • you have a value of ‘italic’ but you don’t import the italic font for Poppins. Some browsers may be able to interpret this, some may not.
    • as an aside, the normal font weight is 400
  • When a user clicks the submit button there should be an error if any fields are blank.
    • you learned how to do this when you made the survey form
  • Please, please, please, make that button look like a button and not a bar
1 Like
3

Thanks @Roma once again! You make this whole experience fun, I am learning a lot from you!

1 Like