FCC project 1: Build a Tribute Page

Code Feedback
1

Hello everyone, I started a few days ago the Responsive Web Design course and today I managed to complete the first test :japanese_goblin:.
What could’ve been done better? Any feedback is appreciated.
Github: https://katroya.github.io/ronswansontribute.github.io/

Codepen:
https://codepen.io/Katroya/pen/yLYqyVm

2

1 Like
3

Welcome to the forums @Katroya. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • Your page passes 8/10 user stories.
    • The test script should be included, with all tests passing, when you submit your projects.
  • Maybe it’s an inside joke but I don’t understand redacting the names.
    • Black text on a black background
  • Don’t use <br> to force spacing. Use margin and/or padding in CSS.
2 Likes
4

Thank you for your time.
Yes it’s an inside joke from the show parks n’ rec, I’ve made the change according to your feedback, and adjusted the footer.

Test now gives 10/10.
https://codepen.io/Katroya/pen/yLYqyVm

2 Likes
5

Second test complete my guys. Thank to these tests I’ve been able to see what I haven’t understood that well.
We’ll see how the next will fare.

Github: https://katroya.github.io/anintrusivesurvey.github.io/

Codepen:

6

Looks okay @Katroya. Some things to revisit;

  • Don’t use in-line styling. All your styling should be external.

  • Don’t use <br> to force line breaks. Use CSS

  • Run your HTML code through the W3C validator.

    • There are coding errors you should address.

  • Change the cursor to a pointer when hovering over the submit button.

  • You should create a new topic for each project otherwise it may get over looked.

7

Ah thank you for the validator, I’ll be sure to run it before posting anything.
Fixed the code according to your feedbacks.
Thank you for your time.