Responsive web design projects feedback needed

Code Feedback
1

Hey guys, I have started my adventure with FCC around early June, having had only some basic understanding of HTML (thanks good old blogging days!). I am currently on the Functional Programming part of JS and struggling immensely, but not giving up.

I am hoping to possibly complete some more courses online (edX etc) and try to get a junior intern position somehow (I don’t have a relevant degree, so for now it just feels a bit like a pipe dream). Just wondering if this is even worth pursuing as I’ve not had any feedback for my work yet, and it’s hard to know if I’m even going in the right direction.

Sorry about the rambling, please give all of the feedback, good and more importantly bad. I’m linking my portfolio project, but if you fancied checking out the other stuff too (would be most thankful), you can access it through there.

Portfolio Page

1 Like
2

Hey there,

nice to meet you! :wave:

Congrats on your project, you did a great job! :clap:

My ideas:

  • all tests pass, awesome!

  • HTML and CSS validation show no errors! :clap:

  • when I decrease the width of my browser, the projects become very small; this is important for people who read your page on a smartphone

Overall there is not much to add! :+1:

Keep up the great work,
looking forward to seeing your next steps! :slightly_smiling_face:

3

Hi @Midget.3.14, I took a look at some of your projects. I didn’t go in-depth as I would do for code review but did see some things you can revisit;

  • Review this for an understanding of the tags in HTML boilerplate
    • Looking at your tribute page for instance, there are elements that are out of order.
  • Don’t use <br> to force line breaks or spacing. That’s what CSS if for.
  • The test script should be included, with all tests passing, when you submit your projects.
    • Your tribute page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Review the lesson about giving meaningful text to links.
    • Web Accessibility in Mind has a more thorough explanation.
    • “guardian” and “wikipedia” on your tribute page are not accessible
  • All your pages should be responsive
    • The product landing page gets a horizontal scrollbar when the browser is minimized
  • Learn to run your HTML code through the W3C validator.
    • It’s a good way to find coding errors. I didn’t run your pages through it so I’m not sure if you’ll find any errors or not when you use it. Just letting you know it’s there and a good tool to utilize.