Project feedback___Tribute Page

Project Feedback
#1

Hey guys,

I’d love some feedback on my project. It started off as the “Build a Tribute Page” and I ended up going a bit further into it, trying to use as much of the topics covered in the lessons as I could in a sensible manner. Any insights/critiques are welcome!

Here you go: Tribute Page (FCC)

Thank you in advance.
Cheers,
Mihael.

2 Likes
#2

Welcome to the forums @mihaelsouza. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 3/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Run your HTML code through the W3C validator.
    • There something you should be aware of and address.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
#3

Hi @Roma , thank you very much for the feedback!

I did not know about the W3C validator, that is a nice tool that I’ve saved to be sure to use often.

And removed all the uses of the <br> tag from the document, thank you for the link. I did not think about how it would appear to a screen reader.

For the user stories, however, I’m unsure. I had removed the unit testing only at the last version of the website. I’ve put it back in, but running it before making any changes was passing 9/10 stories. The only one missing was the “element containing id=main” that I had accidentally removed when refactoring the HTML structure. Now it shows passing all 10, even when I try it out on mobile. I’d be curious whether the same happens for you, if you have the time to take a look at it again.

Once more, thank you for taking the time!
Mihael

#4

All the tests are passing @mihaelsouza. Nice job cleaning things up.

Look forward to seeing your future projects.