LMAE
September 21, 2018, 8:16am
1
I finally completed my projects. Can someone give me feedback before I submit?
Edit : Fixed Ideas and alter image size.
Tribute Page
Edit: Added for label.
Form Page
Product Page
Edit: Fixed Layout
Documentation
Edit: Fixed typo and updated image thumbnails.
Portfolio one
sorinr
September 21, 2018, 8:25am
2
Ok. 1st glance on Waffle project:
you are using the wrong way the id="img-div"
all over. the ids are supposed to be unique. just make it as a class and change it accordingly in both html and css.
if its possible try to make all images in “type of waffles” section same width and height.
sorinr
September 21, 2018, 8:27am
3
As for #2 Survey form just add the for
attribute to all labels to link the label to the related input field.
LMAE
September 21, 2018, 8:33am
4
Thank you for your help. I will fix the ids and image sizes.
Great tribute page! I liked the “Cardboard Eggo Waffles” title!
I think whitespace could be cleaned up so that CSS indentation is consistent. E.g. CSS Line 21 has greater indentation than the rule on the next line.
Is display: block
required for #tribute-info ? I think divs
are block by default.
Multiple elements have an id of tribute-link
for the site links at the end of HTML, but ids should be unique for the whole document according to the docs https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
Happy coding!
LMAE
September 26, 2018, 10:23pm
6
Thank you for your help. I will fix it right away.