Feedback for the My Tribute Page

Code Feedback
1

Hello everyone! I made my first project, so I need constructive criticism :blush:

2

Hello @just_p,

First, for a beginning it is good! Now one point I think you should considerate is the structure of your HTML. All his content should be within the tags body.

<!DOCTYPe html>
<html>
  <!-- The head tags are important because they define the meta data of your page/website -->
  <head>
    <meta charset="utf-8" />
    <!-- In CodePen, you don't need the link tag below, but I find it is still. good habit to take -->
    <link rel="stylesheet" type="text/css" href="css/style.css" />
    <title>Your Page Title</title>
  </head>
  <body>
    <!-- Here should be your HTML code, the one you did -->
  </body>
<html>

I know, it works well without these updates, but they are necessary. It is like in CSS, if you got only one property into one CSS definition you can not put the semicolon “;” at the end of the property: value. But it is not because it works that people should do like this. It should always have the semicolon at the end of a CSS property.

After, for the CSS, everyone does as he wants. Just look what you can optimise and here you go. The more you will practice the more you will realize! :wink:

1 Like
3

Good job overall. I would probably style that figcap perhaps, but that’s just a visual preference thing.
You go =)

4

Welcome to the forums @just_p. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    The test script, with all tests passing, should be included when you submit your projects.
    Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    “статью на wikipedia” is not accessible

On a side note, you’ve used codepen correctly.
Codepen provides the boilerplate for you and only expects the code you’d put within the body element in the HTML editor.

In the future, when asking for feedback on a project it’s best to open the topic in the #project-feedback subforum.
I’ve taken the liberty of moving this for you.

1 Like
5

Yes, the appearance should be improved. Thanks for the feedback

6

Thank you so much for your feedback! I corrected everything, now the score is 10/10

7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.