Feedback on first two projects

Project Feedback
#1

I have completed the first two projects successfully but haven’t had any human feedback on anything code-related. I just want to make sure I’m not making any horrifyingly terrible mistakes. Any feedback is welcome, especially on the second project which I just completely redid the CSS on to be in flexbox.

Tribute Site: https://codepen.io/jeengland/pen/VgWwYp
Survey Form: https://codepen.io/jeengland/pen/ZwevVj

Thanks in advance :grinning:

1 Like
#2

Your tribute page is good, the page is responsive, it is easy to read and the code looks mostly clean. Your last 2 rules in your css you are repeating yourself, you can shorten

h1{
font-family: ‘Arimo’, sans-serif;
}
h2{
font-family: ‘Arimo’, sans-serif;
}

to

h1, h2{
font-family: ‘Arimo’, sans-serif;
}

Your survey page is good too, the colors fit well with each other and the page is very responsive. The animation to the required star is a good touch. The button looks good, you could probably add a #submit-button:hover rule in your css

1 Like
#3

Thank you so much for the feedback. I’ll be sure to implement those changes!

#4