Feedback on Kojima Tribute page

Code Feedback
1

Hello everyone,
I just created a tribute page project for fcc. Link to my project is : https://codepen.io/hvyas/full/jOWMGzq

I would love to hear feedbacks from everyone and what other improvements I can do on my project.

Thank you in advance :smiley_cat:

2

Looking great :+1: :slightly_smiling_face:

1 Like
3

Welcome to the forums @Lucifellow. Page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
    • you have elements placed incorrectly. the link to the font and the stylesheet should go in the head element.
  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address.
  • Don’t use <br> to force line breaks or spacing. That’s what CSS is for.
1 Like
4

Hello @Roma
Thank you for taking time to review my code and give feedback.

I have updated my code based on your feedback.

W3C is really useful to find errors, thanks for giving link to validator I can use it for my future projects.

Thank you for letting me know about alternatives to br . I replaced all my br with margin in css and it gives much more freedom to line breaks.

Thank you for helping me out to improve my code. :smiley_cat:

1 Like