Feedback on My First Project - Louis Pasteur Tribute Page

Code Feedback
1

Hello Campers. A feedback on my tribute page would be much appreciated https://codepen.io/rajeshchandran/pen/RwPvRjp

2

Namaste :pray:
Your project is cool!
Things to amend -

  • The image is too big for the screen. Size it down a little bit, it covers the whole screen.
  • Use the *{padding:0px; margin:0px;} in your CSS, to remove the default browser settings. It will look good.

All other things are pretty decent. You can also try some different color themes.
Can you lend me your time too?
I’ve also completed this same project today can you give your valuable feedback on my project. Below is the post -
http://forum.freecodecamp.org/t/tribute-page-project-feedback-please/

Thanks in advance!

3

@zippytyro Thank you so much for the valuable input. I will make sure to try them out and see how it changes my page.
I did take a look at your page - you have some fancy styling going on there :grinning:
I wish to get to that level soon.

4

Welcome to the forums @RajR, your page looks good. A couple of things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your project.
  • Since you made the dates bold in your timeline and that sets off the start of each one maybe get rid of the bullets
  • Review the lesson about giving meaningful text to link.
    • ‘clicking here’ is not accessible
  • There’s a bit of overkill with all the fonts you list. It will never get past ‘sans-serif’ so you can get rid of all the others. And you have ‘Roboto’ in that list thought you don’t link to it or import it.
5

Hello Roma,

Thank you for making the recommendations. I have made the following changes to my code:

  • I have added the test script at the top of my html.
  • I removed the bullets by adding list-style-type property to my CSS and set it to none.
  • I made my anchor tag to external source link more meaningful.
  • And got rid of all fonts other than Helvetica Neue and sans-serif.
1 Like