Finished A Survey Form Project - Feedback

Code Feedback
1

Hi, I’ve just finished my second project from freeCodeCamp.org, glad to hear some feedbacks and ideas from you guys, help me to be better day by day :slight_smile:
#newlearner

Thank You! :+1:

2

Hi,

It looks really nice.
Clean, clear, it’s ticking all the boxes. I like the styling of the radio buttons and checkboxes. Detailed and well done, you’ve used grid for the yes no buttons effectively.
There are a few details I would work on:
the gradient goes all to white and you’ve made it quite transparent. Because of that the letters can be a little difficult to read on the right edge of the screen.
You don’t always use the for-attribute in labels. It does make your page more accessible. The curriculum states that :

It is considered best practice to set a for attribute on the label element, with a value that matches the value of the id attribute of the input element. This allows assistive technologies to create a linked relationship between the label and the child input element

So I would that. This quote comes straight from the challenges in basic html and css

I would give some attention to the font sizes when the size of screen decreases. It will make your page more readable and pleasant to look at.

The box shadows of the form are great but I don’t see the white at all. If I replace it by a green for example, there’s no green anywhere.

Didn’t know about the resize property. Very cool, learned something new.

2 Likes
3

Your form looks good @bobbyseptianto. Something to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
1 Like
4

Thank you :v: I have added the test script and all tests passed :pray:

5

Hii,

I’ve added the for-attribute in all labels, glad you corrected it! Thanks for reminding me :pray:

I’ve fixed the font sizes, so when the viewport is decreased, it become more readable, thanks to youuu mate :pray:

and I’ve changed the gradient color too

Revised: https://codepen.io/bernardusbobby/full/wvGgWrp

1 Like
6

You are very welcome

1 Like