Hi every one I need your suggestion for my first project.
Thank you.
https://codepen.io/Nabila95/pen/rNxeoBa
Hi!
Try to make it pass all tests?
Image is not centered: expected 0 to be close to -20 +/- 11
Hi Nabila,
You donât need padding style for your image , if you want the image to be smaller than the container, you could just set : max-width:90%
.
hi @nabila
just want to add what others have mentioned, try to use the css analyze tool in codepen.
you have typo at height property in your img selector.
there is unknown property of image: center.
to centering image in their container, you just need display: block;
and margin: auto;
.
Hello!
Thanks a lot for your suggestion.
I have already pass all tests.
Hey, well done!
One last suggestion: youâve added âtribute pageâ to stuff for head section in settings.
HTML editor of codepen was supposed to be <body>
tag of your project, and stuff for head is <head>
tag, it can be used for adding fonts, meta tags, scripts maybe etc, of course itâs not that strict, there are options. Donât think you need this line there
Hi
Thank you again for your suggestion.
Your page looks good @nabila. Some things to revisit;
- When you add something to the
head
in codepen it should still be in the format as if you had thehead
element. You see âtribute pageâ under the test hamburger because thatâs what you typed into âStuff for <head>â. The proper format for that is<title>tribute page</title>
- Run your HTML code through the W3C validator.
- Since copy/paste from codepen you can ignore the first warning and first two errors.
- There are HTML coding errors you should address.
- If you review your page youâll see everything is a serif font. Thatâs because you have a typo in the font family. It should be
sans-serif
- Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation
- âwikipedia entryâ is not accessible
As an aside, the project say to make it âfunctionally similarâ and âgive it your own styleâ. Try to do your own thing, not a rehash of the FCC sample projects.
Hello!
Thanks a lot.
Sorry what do you mean by âwikipedia entryâ is not accessible.
Can you please explain it for me, because itâs about two months that i start learning web development and i donât any thing about that.
Thank you.
If you read the links I included it explains it.
Briefly, if someone is using a screen reader then just hearing âwikipedia entryâ will not mean anything to them. You need to make the link make senseâŚmake it accessible.