First project: Tribute page (Kobe Bryant)

I Built This
1

Hello guys, i just finished my first project i got approved, just want to know if it’s good at all for people not just pass at the test.

Here’s the code: https://codepen.io/Jorge79/pen/YzPbWjv

2 Likes
2

Were you able to include the test suite using codepens settings?
Also I would make the first headings have a background like purple will work (instead of white)

Kobe Bryant
aka: The Black Mamba

1 Like
3

Hi @JorgeSantos, welcome back. Your page looks good. Some things to revisit;

  • Don’t use the <br> element to force spacing. Use margin and/or padding in CSS
  • Yellow lettering on a white background is very hard to read. Bad UX
  • Review the lesson about giving meaningful text to links
  • Just a suggestion but since you’ve made the dates bold, remove the bullets from the list. It’ll look cleaner.
  • Add some padding or margin for smaller screens so text does not butt against the outer edges.
1 Like
4

Thanks for the advices guys, already made the changes :slight_smile:

1 Like