Here is my tribute page and don't forget to comment

Code Feedback
1
1 Like
2

@natiaddis I like your work here. It’s a great start! I like that you don’t style ids and that you don’t use inline styling. Here are some of the issues I’ve found for improvement:

  • Your <img> element needs to have an alt attribute. Here’s some information about that.

  • You have an <h3> heading before your <h1>. This may be confusing to people using screen readers and search engines. Here are the usage notes from Mozilla:

    • Heading information may be used by user agents, for example, to construct a table of contents for a document automatically.

    • Do not use lower levels to decrease heading font size: use the CSS font-size property instead.

    • Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

    • You should consider avoiding using <h1> more than once on a page. See “Defining sections” in Using HTML sections and outlines for more information.

  • You can see the above two errors and a couple more by validating your HTML.

  • I’m not totally comfortable with Bootstrap yet, so I may be wrong about this, but it seems that some of your bootstrap is either not necessary or not doing what you’re wanting it to do. For instance, what do you want the following to accomplish:

    <div class="col-xs-10 col-xs-offset-1">

    Again, I’m not too knowledgeable on this so your feedback will help me learn more. Thanks!

3

Thank you. All your comments are very helpful.

  • For the alt attribute in <img>, I think I forget to add it.
  • I had no idea the heading would be confusing. As you said I used to decrease the font size so I’ll fix it.
  • I’m not good in Bootstrap either but my intention was to align a div 10 columns wide in the center(assuming you know about Bootstrap 12-column grid system) by giving the div a width of 10 columns and one blank column from left leaving one column on the right after the div(1-10-1). But I’m not sure if it is a good idea for centering your div. I think in Bootstrap 4 they have classes for a div to align it horizontally.

Again, Thank you for your comments and useful links. I’ll try to improve my page so don’t forget to check it out and leave your comments. I hope my English was not bad.

1 Like