Tribute page for review

Tribute page for review
0

#1

Build a Tribute Page Project Questions, Discussions, and Resources (January 2018 Cohort)
#2

Looks good, me personally would have made the lists text-size a little bit bigger and also the h4 shouldnt be inside a list. For the quotes, I would have used the blockquote tag.


#3

made your edits! Thanks! Put some thin top/bottom borders on my blockquotes as well.


#4

@bdfoz Looking great! All tests pass. :clipboard: Here are some suggestions you can consider for improvement:

  • Bootstrap: It’s ok to use bootstrap for this project. It seems like your use of bootstrap is correct as well. Nice work! Since you finished this early and there’s plenty of time until the deadline, you may want to challenge yourself further by re-creating the site without bootstrap. Here’s the text in the test suite regarding the tech stack one is expected to use for this project:

    You can use HTML, JavaScript, and CSS to complete this project. Plain CSS is recommended because that is what the lessons have covered so far and you should get some practice with plain CSS. You can use Bootstrap or SASS if you choose. Additional technologies (just for example jQuery, React, Angular, or Vue) are not recommended for this project, and using them is at your own risk. Other projects will give you a chance to work with different technology stacks like React. We will accept and try to fix all issue reports that use the suggested technology stack for this project. Happy coding! [Emphasis Mine]

  • Heading Levels: You mostly keep the heading elements in order except for the last h4 and h6. If you’re wanting to make the font size smaller for the byline text, like the default styling for h6, I think it’s better to keep the correct order of the heading levels by changing the h6 to h5 and then changing the font size via CSS. You may also want to re-visit your h4 element that’s within the blockquote element in case you’re using that h4 for styling instead of heading hierarchy. I wrote about this in more detail in this cohort comment about headings.

  • Main Element: If you use the main element instead of <div id="main">, you can gain an interesting accessibility benefit, as mentioned in the Jump Straight to the Content Using the main Element challenge:

    The main tag also has an embedded landmark feature that assistive technology can use to quickly navigate to the main content. If you’ve ever seen a “Jump to Main Content” link at the top of a page, using a main tag automatically gives assistive devices that functionality.

  • Use of em: I think you may be using the em element incorrectly (<em>A Theologian Hero</em>). Your usage seems to be solely for styling and not emphasis. You can read more about the em element in the Mozilla Developer Network documentation:

    Typically this element is displayed in italic type. However, it should not be used simply to apply italic styling; use the CSS styling for that purpose.

Overall, you’ve done a really great job here :sunny: and I look forward to seeing this project with pure CSS if you choose to accept that challenge. :rocket:


#5

I accept your challenges, all of them!

I still struggle with the whole ‘no-styling-in-html-at-all…ever’ philosophy. This seems to have caught on most with HTML5. It’s a great reflex, given that most of them are geared toward aiding accessibility and devices that help with that. I’m just still not great at it, and I think a hardline is difficult (after all, isn’t structure inherently a type of style as well?). I learned HTML before HTML5 was out, so that’s the most difficult part. If it means a person with vision difficulties can interact with my code better, though, it’s a skill worth learning. Looking forward to getting better at it.

I very much appreciate your close look :wink:

Looked over the MDN thread on <em> to get started! (The above seems like a correct use!)

An example for <em> could be: “Just do it already!”, or: “We had to do something about it”. A person or software reading the text would pronounce the words in italics with an emphasis.


#6

@bdfoz Awesome! :fireworks:

I think you’re suggesting that <em>A Theologian Hero</em> in the context you’re using it is the correct usage of the emphasis element. If so, I disagree, but it’s your project so feel free to ignore my opinion as needed. :smile: I’m not an expert on any of this!

I think A Theologian Hero is more of a heading, like you have it as h2, and you can get the same formatting without using em and instead, selecting the h2 with CSS and giving it font-style: italic.


#7

this is a link to my FCC tribute page. please suggest corrections where necessary…


#8

@camper i was saying this was a correct usage. I agree with your assessment of the h2!


#9

look ok for me as well,

One thing (I might be wrong) is figcaptions. I would write there just info what is on the img, author and source of photo I would put somewhere in footer instead straight away as figcaption.

:slight_smile:


#10

Thanks for that feedback.

@camper, here’s my attempt at no bootstrap: https://codepen.io/bdfoz/pen/ddbWNo?editors=1100


#11

@bdfoz The refactor looks good. One important thing I think you’ll want to fix is to remove one of the id="title"'s in your HTML. As we learned in the Set the ID of an Element challenge:

id attributes should be unique. Browsers won’t enforce this, but it is a widely agreed upon best practice. So please don’t give more than one element the same id attribute.

You may also want to change your ID selectors to classes, as noted in the ID Selector section of the fCC guide:

ID should be avoided when styling if possible. As it has high specificity and it can be overriden only if you inline styles, or add styles into . The weight of ID override class selectors and type selectors.

Other than that, I think you may be missing an end </div> tag somewhere near the bottom of your HTML, but it could be somewhere else, I’m not sure. If you paste your HTML into the HTML validator, you’ll see what I’m referring to. :sunny:


#12

Hi everyone,

I just discovered this awesome site and started to follow the guide step-by-step.

It seems that I was able to complete my first project and your reviews are super important for me!

So here is the link of my project. Please write whatever you want, let me have the feedback.

Thanks!