I’d like some feedback on my portfolio. Such as colors, fonts, layouts, any typo that you find. any little details. What can I improve. I appreciate it. my portfolio url is https://dainr.github.io
Not trying to be rude or harsh but how/why did you claim the RWD certification?
The projects should be submitted with all user stories passing. The test script should also be included.
There’s one project, the technical documentation page that you didn’t do.
None of the four projects you submitted passes all user stories. Some only pass one and that one is a gimme.
- page passes 1/10 user stories
- it’s not responsive
- there are syntax errors. Run your HTML code through the W3C validator
- The tribute link is not accessible. Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
- page passes 2/17 user stories
- it’s not responsive
- don’t use the
<br>element to force line breaks or spacing. That’s what CSS is for.
- page passes 3/16 user stories
- there are syntax errors. run it through the W3C validator
- no feedback because you didn’t do this required project
- page passes 2/12 user stories
Thank you for the feedback. Coding is not my thing, I tried it for this little while. I will take some time off and try some other options out there.
I’m not sure why you say that. Your pages look good. It’s just that instructions were not followed.
Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>) so you can check to see if user stories have been met. If a test fails just click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
Or, as the instructions say you can use this CDN link to run the tests in any environment you like:
If you look at the feedback that I gave, four of your projects (you need to do that other one) all have one thing in common and that’s that the user stories weren’t met. There were two of your projects with syntax errors so you picked up something. Everyone occasionally makes syntax errors, that’s why the validator is a good tool to keep and use.
The styling of your pages is good. You have a keen eye for design. Two of your projects weren’t responsive but it’s easy enough to make them so.
You asked for feedback, what you can improve. I gave you that. Don’t get discouraged because of honest feedback.
You’re learning. Feedback helps you to learn and grow. It should never make you give up.
I went over two of the projects and follow the testing.
tribute page https://dainr.github.io/tribute-page/
survey form https://dainr.github.io/survey-form/
I will work on the rest to finish them by the end of the week
I agree your page looks good. It is a really clean design. Couple things is the top image background seems to resize when I scroll down which looks a bit odd and the nav links need to offset the fixed navbar.
Nice job meeting the criteria @dainr. Some things to revisit;
- Not sure if you noticed but even though you’re using the
strongelement the text on your page doesn’t render as such. This is because the
linkto your font only has the regular weight. The browser doesn’t know how to handle a heavier weight so it does nothing. What you need to do is select the regular weight (style for regular 400) like you did but also select the bold weight (style for bold 700).
Hope that makes sense. Ask me to clarify if it doesn’t.
The form looks good. While it’s not a requirement one thing you can go back and take a look at is accessibility. A user who navigates using the keyboard cannot tell where they are within the form.
Like I said, it’s not a requirement right now but it is something you’ll want to learn about and be aware of.
About the strong element, on my screen I can see that its bold. When I run my code in the browser I can see that the date is bold. Much heavier and darker than the rest of the text. About the form, I have little knowledge of how to add that kind of accessibility, once I research it I will add it to my page.
Some browsers will handle it, a lot won’t be able to so it’s best to incorporate the the link so that it contains the regular weight and the bold.
It’s also possible that you have that font loaded onto your box which is why you’re able to see it correctly. I, and most other, do not.
Yes, something to research in your spare time.
Just so you know, this is why there’s no focus
It’s used four (crucial) times in your stylesheet.