Just earned my first certification-- portfolio page: feedback

Code Feedback
1

I’m super happy to have completed my first programming section in freecodecamp. I definitely want to refine all my documents later when I learn more, but I am proud to have finally completed the first step towards learning javascript!

Please give me feedback on my last document in css / html =)

Document: https://codepen.io/daniel-albano/full/qBWrdoV

1 Like
2

Love the site and the social icon animations. Good work.
The typography is apt.
The design is correctly applied.

Like the site though there is always some room for improvement.
You can add background image on the landing part, that would look more better.

1 Like
3

Thanks! the background image is something I was definitely considering to add later on, replacing the first gradient.

4

beautiful social media icons! But why you add social media icons when they don’t go anywhere?

1 Like
5

Hi @danmcto, nice. There are a few things you may want to revisit;

  • codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • a typo in CSS that affects how your page displays
    • in HTML, you use an id more than once
  • the projects links all point to the same thing
1 Like
6

Sorry for such a late response, but I do not have a place to take them yet. I plan to assign destinations when I’m ready to work though.

7

Thank you for the feedback, I probably wrote one string of data then copy and pasted the project links code section and forgot to change the hrefs lol.