Landing Product Page - Feedback needed!

Code Feedback
1

Hey coders,
I’ve just completed my product landing page and would love to receive any feedback please?

Many thanks,
Andre

2

Try making your browser as skinny as possible and notice the issue with the menu at the top. Also, you’ll get a horizontal scroll bar. These issues definitely need to be fixed for this to be considered responsive.

1 Like
3

Your page looks good @8ty7. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • Keep all of your styling external. Get rid of the style element.
      The @import and the body selector belong in codepen’s CSS editor
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    • You learned to do this when coding the survey form
  • and as previously mentioned, make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens
1 Like
4

i just wanna say that it looks really cool. I love the icons of food you added on either side. Really nice!
i’m not sure if im allowed to just comment something like this or if it has to be advice…

1 Like
5

Thanks a lot for the feedback, appreciate it!

6

Thanks…Happy coding!

1 Like
7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.