Responsive Product Landing Page - Feedback

Code Feedback
1

Hey there! I finished my third project today, and I’m pretty happy with what I was able to create. Any feedback would be appreciated :slight_smile:

https://codepen.io/The-Lazy-Coder/full/YzpgByg

2

Your page looks good @TheLazyCoder12. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 15/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There is an HTML coding error you should be aware of and address. (This is HTML5. Get rid of that obsolete attribute and use CSS)
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    • You learned to do this when coding the survey form
  • Change the cursor to a pointer when hovering over the submit button
1 Like
3

Hello! I finally finished tweaking my product landing page and I was wondering if anyone could give me some feedback now that it’s actually complete.

Here’s the link: https://codepen.io/The-Lazy-Coder/full/YzpgByg

Thank you ^^

1 Like
4

Hi @TheLazyCoder12 !

I think your page looks good.

The only thing that I noticed was that the navbar links disappear completely at a center break point.

So maybe it would be better to play around with a hamburger menu for smaller devices.

Keep up the good work!

1 Like
5

Great idea! I’ll look into that.

1 Like
6

@TheLazyCoder12, as I mentioned previously;

Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.

  • You learned to do this when coding the survey form
7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.