Feedback: Product-landing-page

Code Feedback
1

Hello again!
I hope if you guys could give me a feedback about my 3rd project in responsive web design
Here’s the link:
https://codepen.io/masmarmehdi/full/LYZqdem
I’ll be so thankful !! :smile: :raised_hands:

1 Like
2

Hey @mehdimasmar.
Your page looks nice. There are somethings to rework.

  • give some margin to sign in section caption.
  • Add at the footer text like “made by mahdimasmar”.

That’s my feedback.

Thanks and Happy Coding :grin:

1 Like
3

Thanks for your feedback :smile: :raised_hands:

4

One of the goals of these projects is to make them responsive. When I narrow my browser all the way in the three boxes near the bottom get very skinny. I think you need to change their layout to one column at some point so they have more room with narrower view ports.

Also, at a narrow width the text below the submit button at the top breaks out of its gray container. And I’m not sure you should be satisfied with the way the nav links at the top behave either.

1 Like
5

Thank you for this feedback i appreciate that

6

Nice work. Not responsive though and i think you could add some colors.

1 Like
7

Thank you for the feedback :smile: :raised_hands: i’ll try to improve it

1 Like
8

Your page looks good @mehdimasmar. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There is an HTML coding error you should be aware of and address.
      • FCC teaches and you’re using HTML5
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it, there’s an error that will affect how your page displays.
      • After correcting, run it again until it says no errors found. Be wary of duplicating properties.
    • (The one for HTML misses things which is why I recommend W3C)
1 Like
9

OMG you always saving me thank you so much!!! :smile: :raised_hands:

1 Like