Hello everyone,this is my portfolio
Well i think it looks pretty. But when i examined your code i realized that there are some codes that do nothing. For exemple, Dior project/css/line 85 . In general i think your portfolio is good.
1 Like
Hello there @Kseniya great effort so far.
- Although this doesnât really matter much but Iâd advice having at the very least an image preview of your projects. In real world scenarios this is considered highly important I think.
- Ideally when you set up
:hover
on elements you want them to happen over time which you did with your nav but seems to be missing on every other elements. - You did a good job adding the hero image.
- You seem to have a stray
<div>
on line 23. This might be as a result of your<div class="container flex-between-center">
being closed immediately on line 9. - In place of âSome of my projectsâ you can use âMy projectsâ. If you have more than the projects on display itâs fine not to include every single project you worked on but displaying your best works is important. If anyone needs to see âallâ of your projects they can always request your GitHub or Codepen username.
- Lastly in place of âContactsâ you can use âContact meâ which sounds a bit better.
Youâre off to a great start but it doesnât end here. Keep practicing, keep learning and keep coding. This might be late but welcome to the FCC community. Happy coding !
1 Like
ââŚhaving at the very least an image preview of your projectsâ
Definitely agree. I would say an image of your pages is a must. Preferably not a boring screen shot either.
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.